Skip to content

Commit

Permalink
dependencySatisfies only reliable with a peerDep
Browse files Browse the repository at this point in the history
This addon uses `dependencySatisfies` to check the ember-source version. But unless you have a peerDep on ember-source, that was unreliable depending on Yarn/NPM optimization behaviors. And now as of embroider-build/embroider#1070 we're making `dependencySatisfies` strict so that it won't accidentally work sometimes when you don't actually declare a dependency or peerDependency.
  • Loading branch information
ef4 authored Jan 13, 2022
1 parent 1eba44a commit b41602e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@
"release-it-lerna-changelog": "^3.1.0",
"webpack": "^5.55.1"
},
"peerDependencies": {
"ember-source": "^3.8 || 4"
},
"engines": {
"node": "12.* || 14.* || >= 16"
},
Expand Down

0 comments on commit b41602e

Please sign in to comment.