Skip to content

Commit

Permalink
Because @ember/test-helpers uses a macroCondition looking at ember-so…
Browse files Browse the repository at this point in the history
…urce, and declares a peerDependency, we must use depMeta*injected
  • Loading branch information
NullVoxPopuli committed Jul 24, 2024
1 parent 23aa201 commit f84c442
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ jobs:
- name: Build addon
working-directory: addon
run: pnpm build
- run: pnpm i -f # sync injected dependencies
- run: pnpm test
working-directory: test-app
- name: own types
working-directory: addon
run: pnpm tsc --noEmit
Expand All @@ -61,7 +63,9 @@ jobs:
- name: Build addon
working-directory: addon
run: pnpm build
- run: pnpm i -f # sync injected dependencies
- name: Run Tests
working-directory: test-app
run: pnpm test
- name: own types
working-directory: addon
Expand Down Expand Up @@ -103,6 +107,7 @@ jobs:
- name: Build addon
working-directory: addon
run: pnpm build
- run: pnpm i -f # sync injected dependencies
- name: test
working-directory: test-app
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
Expand Down
36 changes: 32 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,18 @@
"test": "ember test",
"test:ember": "ember test"
},
"dependenciesMeta": {
"@ember/test-helpers": {
"injected": true
}
},
"devDependencies": {
"@babel/eslint-parser": "^7.21.3",
"@babel/plugin-proposal-decorators": "^7.21.0",
"@ember/jquery": "^2.0.0",
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.0.1",
"@ember/test-helpers": "workspace:*",
"pretender": "^3.4.7",
"@embroider/test-setup": "^4.0.0",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
Expand Down Expand Up @@ -60,6 +64,7 @@
"eslint-plugin-qunit": "^7.3.4",
"latest-version": "^5.0.0",
"loader.js": "^4.7.0",
"pretender": "^3.4.7",
"prettier": "^2.8.7",
"qunit": "^2.21.1",
"qunit-dom": "^3.2.0",
Expand Down

0 comments on commit f84c442

Please sign in to comment.