Remove code for pre-ember-v4 #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
remove-code-for-pre-ember-v4
branch
from
3e22660 to
da9ec25
Compare
|
Something seems wrong with |
NullVoxPopuli
force-pushed
the
remove-code-for-pre-ember-v4
branch
from
da9ec25 to
0e68ac4
Compare
NullVoxPopuli
force-pushed
the
remove-code-for-pre-ember-v4
branch
from
60c8f34 to
c453f8c
Compare
|
Talked with @NullVoxPopuli and think this could also be good to have in a 3.x release. |
NullVoxPopuli
commented
May 31, 2023
| @@ -129,55 +128,33 @@ export function render( | |||
| let OutletTemplate = lookupOutletTemplate(owner); | |||
| let ownerToRenderFrom = options?.owner || owner; | |||
|
|
|||
| if (macroCondition(dependencySatisfies('ember-source', '<3.24.0'))) { | |||
There was a problem hiding this comment.
this code change is the removal of this if branch, keeping only the else
…ng @glimmer/manager brought in newer types -- this will be simplified in the next glimmer-vm release
…anager, since we can't add @glimmer/manager as a devDependency, becaues that triggers some correctness checking in webpack that (correctly, but fights against our weirdness) throws an error that we're importing from @glimmer/manager when it's a devDep instead of dep
…ager as a devDependency
NullVoxPopuli
commented
May 31, 2023
| // SAFETY: in more recent versions of @glimmer/manager, | ||
| // this throws an error when maybeComponent does not have | ||
| // an associated manager. | ||
| try { |
There was a problem hiding this comment.
It appears that @glimmer/manager changed its behavior. This change absorbs the change in @glimmer/manager
MelSumner
approved these changes
May 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember v4 is a requirement for the next release of
@ember/test-helpers, so we can drop some code branches.