Switch to pnpm, upgrade ember-cli-babel to 8.2 #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Jul 19, 2024
NullVoxPopuli
force-pushed
the
switch-to-pnpm
branch
2 times, most recently
from
f704971 to
5fd301f
Compare
|
5.4 and 5.8 should pass as soon as I adjust the ember-try config. release, beta, and canary are expected to fail, as I think they actually have a bug around waiters -- need to look in to that, but is a separate problem from anything this repo can solve, afaik |
NullVoxPopuli
force-pushed
the
switch-to-pnpm
branch
from
50c4893 to
5d97804
Compare
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
switch-to-pnpm
branch
from
5d97804 to
5b0be42
Compare
kategengler
reviewed
Jul 23, 2024
| - ember-release | ||
| - ember-beta | ||
| - ember-canary | ||
| # All of these are failing with the waiter tests (needs to be debugged separately) |
There was a problem hiding this comment.
Can you open an issue so this isn't forgotten?
There was a problem hiding this comment.
there is this one: emberjs/ember.js#20724
kategengler
approved these changes
Jul 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of note, I disabled the try scenarios for
I believe they are failing due to recent changes in ember-source, but in any case, they are very likely unrelated to the following plan:
Planned PRs:
This process will help determine what type of semver bump the next version will be