Fix import type via upgrading @tsconfig/ember #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
|
I'm not sure about this dropping support for TS versions still supported by ember.js itself without doing a major version to indicate changed ember.js support. cc @wagenet @gitKrystan |
NullVoxPopuli
changed the title
…pport -- we only need to test the public API
|
ember-source only tests against 4.9+ of typescript, if that helps |
NullVoxPopuli
force-pushed
the
fix-type-imports
branch
from
1a7ff6d to
82c3b94
Compare
…oesn't exist pre TSv5
|
all green! and no longer dropping support for anything! |
kategengler
approved these changes
Jul 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of the v2 conversion process, we need to correctly declare our type imports as types (rather than values).
This enables tooling later to completely strip imports if unused.
For V2 Conversion
depending on how these PRs go will determine if we need to do a major or not.