Get tests passing w/ Chrome's new selectionchange event behavior #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
fix-test-failures
branch
from
f78fa0f to
33a0619
Compare
NullVoxPopuli
force-pushed
the
fix-test-failures
branch
from
3522b21 to
d300515
Compare
NullVoxPopuli
changed the title
wagenet
approved these changes
Aug 19, 2024
| @@ -18,6 +18,10 @@ if (isEdge) { | |||
| blurSteps = ['focusout', 'blur']; | |||
| } | |||
|
|
|||
| if (isChrome) { | |||
There was a problem hiding this comment.
Why did we not do selectionchange for Firefox since that supports it also?
There was a problem hiding this comment.
The behavior is slightly different.
When I was working on this PR, I had 5 browsers open
- FireFox
- FireFox Developer Edition
- Safari
- Chrome
- Chrome Canary
😅
| 'focusin', | ||
| 'mouseup', | ||
| 'click', | ||
| 'selectionchange', |
There was a problem hiding this comment.
Should we just push selectionchange to the existing list?
There was a problem hiding this comment.
then we'd need to add inverted conditions for safari and firefox
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks: #1470
Last successful build (nightly cron): https://github.com/emberjs/ember-test-helpers/actions/runs/10173407362
Next nightly cron failed: https://github.com/emberjs/ember-test-helpers/actions/runs/10191329093
Findings:
selectionchangeevents in this jsbin demo I made: https://jsbin.com/feseyif/edit?html,outputIn the changes in this PR: