Make it possible to call triggerEvent(fileInput, 'change', { files }) twice with the same files
#923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if you have the time that you can update the defineProperty that we do to add Mind giving that a shot? |
|
I thought that was what I tried with the results in the PR comment, but I can give it another go |
|
Oh, I see! I'm sorry, I missed that those failures were with that change. |
@sdahlbac Just use the Also, it seems |
sdahlbac
changed the title
…into 921-fix-trigger-event # Conflicts: # tests/unit/dom/select-files-test.js
sdahlbac
changed the title
triggerEvent(fileInput, 'change', { files }) twice with the same files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921
Not really sure what I did wrong the previous time, now it seems to work fine.
Also moved the testcase to a better location as suggested.