Move ember-concurrency-specific-tests to the ember-concurrency@v2 test-app #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
extract-ember-concurrency-tests
branch
4 times, most recently
from
7ecc5a7
to
91ceab6
Compare
28 tasks
NullVoxPopuli
commented
Dec 4, 2023
| @@ -45,7 +45,7 @@ | |||
| "@types/ember-test-helpers": "^1.0.10", | |||
| "@types/ember-testing-helpers": "^0.0.4", | |||
| "@types/ember__test-helpers": "^2.6.1", | |||
| "@types/qunit": "^2.11.2", | |||
| "@types/qunit": "^2.19.9", | |||
There was a problem hiding this comment.
this changed because between the different test apps we have different qunit types versions, and it's just easier to have these deps match, than to fix subtrees of the dep graph
NullVoxPopuli
commented
Dec 4, 2023
| @@ -2,27 +2,23 @@ import MockStableError, { | |||
| overrideError, | |||
There was a problem hiding this comment.
all removals here went to the ember-concurrency-v2 app
…t-app config eh eh eh eh eh
NullVoxPopuli
force-pushed
the
extract-ember-concurrency-tests
branch
from
91ceab6
to
fec1395
Compare
NullVoxPopuli
commented
Dec 4, 2023
There was a problem hiding this comment.
same try config as "base-tests"
NullVoxPopuli
commented
Dec 4, 2023
| @@ -0,0 +1,442 @@ | |||
| import MockStableError, { | |||
There was a problem hiding this comment.
This test is the same as it was in the base-test app
NullVoxPopuli
commented
Dec 4, 2023
|
|
||
| // @ember/test-waiters is still a v1 addon and is too weird | ||
| // to have in-repo types working correctly. | ||
| // @ts-ignore |
There was a problem hiding this comment.
ts-ignores can be cleaned up once test-waiters is a v2 addon and actually has types we can consume
chancancode
approved these changes
Dec 4, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context on "The Plan": #458
This extraction is ocurring so that we can more easily also test ember-concurrency@v3, which is very hard to try to test both v2 and v3 of ember-concurrency in the same app.
Requires: #463