Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computed.sort is not updated if the value of the itemsKey is null #15732

Closed
pieter-v opened this issue Oct 12, 2017 · 2 comments
Closed

computed.sort is not updated if the value of the itemsKey is null #15732

pieter-v opened this issue Oct 12, 2017 · 2 comments

Comments

@pieter-v
Copy link
Contributor

pieter-v commented Oct 12, 2017

If the first time you 'get' the sorted property while the property itself is null, then the sorted property is never recalculated if the property receives a value afterwards (see attached file for a reproduction scenario).

works on 2.15.3, but fails on 2.16.0

The reason why this fails in our app, is that property is a sub-property of model (model.users and model.sortedUsers) and that rendering starts between the beforeModel and model hook. So, the value controller.model is still null.
sorting.zip

@rwjblue
Copy link
Member

rwjblue commented Oct 13, 2017

I believe that this was fixed by #15733.

@rwjblue rwjblue closed this as completed Oct 13, 2017
@pieter-v
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants