Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computed.sort broken in 2.16 #15745

Closed
mkamneng opened this issue Oct 17, 2017 · 3 comments
Closed

computed.sort broken in 2.16 #15745

mkamneng opened this issue Oct 17, 2017 · 3 comments

Comments

@mkamneng
Copy link

Hi Guys,

The sorting using Ember.computed.sort seems to be broken in 2.16. I had it working in 2.14 and since my upgrade, it's silently failing to sort.

There is already an issue on sort (#13037, computed.sort works incorrectly with empty sort properties array #13037), but it's not the same I'm experiencing.

I have created a demo for both scenarios:
Sorting with Ember.computed.sort working in 2.14.1: https://ember-twiddle.com/376dab39e1adfd11e93499049b035c41
Sorting with Ember.computed.sort broken in 2.16.0: https://ember-twiddle.com/f6ad4dfab81aa0989268596b0d88c38a

Thanks!

@Techn1x
Copy link

Techn1x commented Oct 18, 2017

There is an issue on the 2.16 sort regression here;
#15732

And a merged PR here;
#15733

Just waiting on a hotfix release...

@mkamneng
Copy link
Author

Ok, Thanks.

@locks
Copy link
Contributor

locks commented Oct 18, 2017

Thanks for reporting, closing this one as it's a duplicate and the issue has been resolved.

@locks locks closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants