Port {{concat}}
helper test to ember-glimmer
#12910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 1:1 port of https://github.com/emberjs/ember.js/blob/master/packages/ember-htmlbars/tests/helpers/concat-test.js to the
ember-glimmer
test directory, with some minor cleanup. We don't have{{#if}}
working yet (working on that next), so I split the "can be used as a sub-expression" test into two (which imo, seemed like a good refactor anyway).The test is sym-linked back into
ember-htmlbars
as usual, so it is ran in both packages.Given that this is 1:1 with the existing test, and it is ran in both packages, is it okay if we delete the existing version here? (I would like to do that, so we can easily keep track of what we have made ported.)
cc @rwjblue