Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer2] Move hash helper to use reference infra #13103

Merged
merged 2 commits into from
Mar 20, 2016

Conversation

chadhietala
Copy link
Contributor

This may or may not be correct. Was just looking at the {{if}}/{{unless}} helpers.

@chancancode
Copy link
Member

I think we want to make a special kind of Reference for this to proxy .get to NamedArgs#get. That way, if you never call HashHelperReference#value directly, we won't have to re-ify that into a dictionary and pull from the other references in the hash.

i.e. Upstream = {{yield (hash a=... b=... c=... d=.. e=...}}, and downstream only uses {{hash.a}} in the template, all won't have to re-ify the other four references (and also make a dictionary/object to hold all of the references/values)

This allows us to not reify the entire hash when consumers perform a
lookup.
chancancode added a commit that referenced this pull request Mar 20, 2016
[Glimmer2] Move hash helper to use reference infra
@chancancode chancancode merged commit 8af7899 into emberjs:master Mar 20, 2016
@chancancode
Copy link
Member

🎉

@chadhietala chadhietala deleted the internal-hash-helper branch March 20, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants