[Glimmer2] Remove void element test #13187
Conversation
|
|
||
| this.render('{{foo-bar}}'); | ||
|
|
||
| assert.deepEqual(fooBarInstance.childViews.length, 0); |
There was a problem hiding this comment.
The original test was checking for childNodes of the components element, not for childViews.
I think this (and the one below) should be:
assert.deepEqual(fooBarInstance.element.childNodes.length, 0, 'no childNodes are added for `<input>`');
|
Small nit-pick, but this looks great, thank you! |
Saranya-Raaj
force-pushed
the
remove-void-component
branch
from
3645a4f
to
4c6f156
Compare
|
@rwjblue Updated, Thanks |
Saranya-Raaj
force-pushed
the
remove-void-component
branch
from
4c6f156
to
a751657
Compare
|
👍 - LGTM I'll leave to @chancancode to do final review + merge (I'm not super great at the I-N-U-R style yet 😸). |
|
☔ The latest upstream changes (presumably #13190) made this pull request unmergeable. Please resolve the merge conflicts. |
Saranya-Raaj
force-pushed
the
remove-void-component
branch
from
a751657
to
c881eed
Compare
|
|
||
| this.runTask(() => this.rerender()); | ||
|
|
||
| assert.deepEqual(fooBarInstance.element.childNodes.length, 0); |
There was a problem hiding this comment.
a small nit-pick, assert.equal is probably clearer here
There was a problem hiding this comment.
When comparing against 0, it's always a good bet to use assert.strictEqual which uses === instead of == :)
Saranya-Raaj
force-pushed
the
remove-void-component
branch
from
c881eed
to
88c6bf3
Compare
| } | ||
| }); | ||
|
|
||
| this.registerComponent('foo-bar', { ComponentClass: FooBarComponent, template: '{{yield}}' }); |
|
Looks good to me! Can be merged after resolving the minor comments above. Thank you @Matrixz! |
Saranya-Raaj
force-pushed
the
remove-void-component
branch
from
88c6bf3
to
03a96d4
Compare
[Glimmer2] Remove void element test
|
Thanks @Matrixz! |
Removed htmlbar void element test and covered it in curly components test.
Part of #13127
cc @chancancode