[Glimmer2] Port {{partial}} test to ember-glimmer. #13199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
rwjblue
changed the title
{{partial} test to ember-glimmer.{{partial}} test to ember-glimmer.
|
All test method descriptions remained the same. |
| } | ||
| }); | ||
|
|
||
| QUnit.test('should render other templates registered with the container', function() { |
jheth
changed the title
{{partial}} test to ember-glimmer.
|
@jheth Thanks so much for doing the initial port. A couple things:
There are some similar problems in the dynamic component ("component helper") case. You can have a look at https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/tests/integration/components/dynamic-components-test.js. |
|
superseded by #13306 |
chadhietala
added a commit
to chadhietala/ember.js
that referenced
this pull request
Apr 12, 2016
This supersedes emberjs#13199
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
This supersedes emberjs#13199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the existing
{{partial}}test to glimmer.As noted,
partialis not support in Glimmer 2 so these are tagged to@htmlbarsThe one addition to the tests is calling
assertStableRerenderIssue #13127