[Glimmer] Port component elementid test. #13208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.render('{{foo-bar id="custom-id"}}'); | ||
|
|
||
| var foundId = this.$('h1').attr('id'); | ||
| assert.equal(foundId, 'custom-id'); |
There was a problem hiding this comment.
This is a new failing test for glimmer2. It still generates an emberXX id.
|
Looks great! @chancancode - r? |
| } | ||
| }); | ||
|
|
||
| QUnit.test('passing undefined elementId results in a default elementId', function() { |
There was a problem hiding this comment.
Ported to @test passing undefined elementId results in a default elementId
|
☔ The latest upstream changes (presumably #13236) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rwjblue I've rebased and pushed. I moved my tests up in the file to be next to the other elementid test. |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved over the one elementid test and added another one for custom elementid.
Issue #13127