New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Move TestCase helpers to internal-test-helpers #14429

Merged

rwjblue merged 1 commit into emberjs:master from trentmwillis:test-case-helpers

Oct 6, 2016

Member

trentmwillis commented Oct 6, 2016

Follow up to #14428. Moves the TestCase and associated helpers into internal-test-helpers.

A couple notes:

To avoid needing to re-write all the imports in the glimmer test suite, I opted to re-export any moved helpers in the same files. If we want to clean that up, I think it should be done in a follow up PR.
I standardized all the "test" classes to have the suffix TestCase; including renaming the base class to AbstractTestCase. If this is undesirable, I can switch it back (mainly did it so that everything is consistent).


          [CLEANUP] Move TestCase helpers to internal-test-helpers

b303567

rwjblue merged commit 8cb2107 into emberjs:master

Member

rwjblue commented Oct 6, 2016

Thanks @trentmwillis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet