improved style deprecation message #14707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
reviewed
Dec 19, 2016
| 'please ensure that values being bound are properly escaped. For more information, ' + | ||
| 'including how to disable this warning, see ' + | ||
| 'http://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes.'; | ||
| export function constructStyleDeprecationMessage(affectedStyle) { |
There was a problem hiding this comment.
You could maybe use a template string here. How do they treat whitespace?
There was a problem hiding this comment.
I wanted to use template string as well, but multiline template string produces multiline result - e.g.:
`Hello
world`
produces:
Hello
world
instead of just Hello world.
I guess this is not the "right" place to use template string - I would have to write the whole deprecation message as single-line which I guess would make the code a little bit messy :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to accomplish #13728