Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation for the Ember Global #19457

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

patocallaghan
Copy link
Contributor

Towards RFC 706

Adds a deprecation for the Ember Global

{
  id: 'ember-global',
  until: '4.0.0',
  url: 'https://deprecations.emberjs.com/v3.x/#toc_ember-global',
  for: 'ember-source',
  since: {
    enabled: '3.27.0',
  },
}

Can this PR be merged as-is or do we need to wait for a new release of ember-cli-babel with emberjs/ember-cli-babel#382?

@patocallaghan
Copy link
Contributor Author

Ah I have some failing tests I need to resolve 😬

@patocallaghan patocallaghan force-pushed the patoc/deprecate-ember-global branch from 2a17bc6 to c9a8c86 Compare March 17, 2021 23:01
@pzuraq
Copy link
Contributor

pzuraq commented Mar 17, 2021

@patocallaghan I'm actually detangling some things to do with this now, turns out that the Globals resolver/namespaces are being accessed when logging class names 😬 I'm going to see if I can't remove that code in a separate PR that you can rebase on top of

@patocallaghan
Copy link
Contributor Author

@pzuraq ah thanks. Yeah it seems to be happening in the internals here in the namespace_search.ts class.

image

@patocallaghan patocallaghan force-pushed the patoc/deprecate-ember-global branch from 6dd1f14 to 04f28b2 Compare March 18, 2021 22:52
@patocallaghan
Copy link
Contributor Author

Rebased to pick up the changes from #19467

@pzuraq pzuraq merged commit c2f5bed into emberjs:master Mar 18, 2021
@patocallaghan patocallaghan deleted the patoc/deprecate-ember-global branch March 18, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants