Initial implementation of the unique-id helper #19882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wycats @MelSumner what do we need to land this? |
This was referenced Feb 10, 2022
|
I created a PR (which targets this branch) that adds the feature flag. |
The implementation works, and still needs: - [ ] Docs - [ ] Feature Flag Co-authored-by: Melanie Sumner <melaniersumner@gmail.com>
ctjhoa
pushed a commit
to ctjhoa/ember-unique-id-helper-polyfill
that referenced
this pull request
Mar 2, 2022
Ember has recently implemented this feature so we can match the polyfill implementation with that version. emberjs/ember.js#19882
nevilm-lt
pushed a commit
to nevilm-lt/ember.js
that referenced
this pull request
Apr 22, 2022
nevilm-lt
pushed a commit
to nevilm-lt/ember.js
that referenced
this pull request
Apr 22, 2022
|
is it expected that IDs produced by this helper don't work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation works, and still needs: