-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate importing inject
from @ember/service
#20526
Merged
kategengler
merged 3 commits into
emberjs:main
from
bertdeblock:deprecate-importing-inject-from-ember-service
Dec 12, 2024
Merged
Deprecate importing inject
from @ember/service
#20526
kategengler
merged 3 commits into
emberjs:main
from
bertdeblock:deprecate-importing-inject-from-ember-service
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Aug 18, 2023
bertdeblock
commented
Aug 18, 2023
bertdeblock
force-pushed
the
deprecate-importing-inject-from-ember-service
branch
from
August 18, 2023 12:16
b187c11
to
db7b2eb
Compare
bertdeblock
force-pushed
the
deprecate-importing-inject-from-ember-service
branch
from
December 8, 2024 08:40
db7b2eb
to
31c0401
Compare
bertdeblock
commented
Dec 8, 2024
11 tasks
bertdeblock
force-pushed
the
deprecate-importing-inject-from-ember-service
branch
from
December 9, 2024 16:04
31c0401
to
0571a60
Compare
kategengler
reviewed
Dec 9, 2024
bertdeblock
force-pushed
the
deprecate-importing-inject-from-ember-service
branch
4 times, most recently
from
December 11, 2024 16:42
a74f729
to
3b4db23
Compare
bertdeblock
force-pushed
the
deprecate-importing-inject-from-ember-service
branch
from
December 11, 2024 16:46
3b4db23
to
c974add
Compare
If you'd like, you can update the deprecation guide to list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20262.