Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate importing inject from @ember/service #20526

Conversation

bertdeblock
Copy link
Member

Closes #20262.

@bertdeblock bertdeblock force-pushed the deprecate-importing-inject-from-ember-service branch from b187c11 to db7b2eb Compare August 18, 2023 12:16
@bertdeblock bertdeblock reopened this Dec 8, 2024
@bertdeblock bertdeblock force-pushed the deprecate-importing-inject-from-ember-service branch from db7b2eb to 31c0401 Compare December 8, 2024 08:40
@bertdeblock bertdeblock force-pushed the deprecate-importing-inject-from-ember-service branch 4 times, most recently from a74f729 to 3b4db23 Compare December 11, 2024 16:42
@bertdeblock bertdeblock force-pushed the deprecate-importing-inject-from-ember-service branch from 3b4db23 to c974add Compare December 11, 2024 16:46
@ijlee2
Copy link
Member

ijlee2 commented Dec 12, 2024

If you'd like, you can update the deprecation guide to list ember-codemod-remove-inject-as-service.

@kategengler kategengler merged commit d5c2f93 into emberjs:main Dec 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate inject export from @ember/service
3 participants