Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

There is no 'helpers/resolver.js' unit test now #2171

Merged
merged 3 commits into from
Jan 16, 2018
Merged

Conversation

myartsev
Copy link
Contributor

No description provided.

@locks
Copy link
Contributor

locks commented Jan 11, 2018

Thank you for the contribution!
The acceptance test image seems a bit smaller than the current one, are you able to update it to match?

@myartsev
Copy link
Contributor Author

I updated it to match the image width, but the height is going to be lower no matter what.
There is one less test case and it appears that the Qunit test reporter layout no longer wraps at that width as per the original image.

@rwjblue
Copy link
Member

rwjblue commented Jan 14, 2018

Hmm, if we are trying to match this, the next time we release (3.0.0) will have even fewer files (tests/helpers/* are all gone now)...

@locks
Copy link
Contributor

locks commented Jan 16, 2018

Thanks for the update. I have created an issue to track the Ember 3.0 changes.

@locks locks merged commit e0b40c6 into emberjs:master Jan 16, 2018
@myartsev myartsev deleted the 9tests branch January 16, 2018 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants