Fixed header search-icon broken link (#2255)

[pakiusdevo]

No description provided.

[jenweber]

Hi @azanbertre, thanks for this! Can you edit to use a relative url instead? I think ../images/search-icon.svg might fix it. That way, no matter what version of the guides someone is looking at, the url still works.

[sivakumar-kailasam]

Thanks for taking the time to contribute to this project. We’re in the process of switching from middleman to an ember app to make it easy for contribution.

We’re closing issue since its been open for too long without progress / it needs more discussion which is probably better had via a new PR in the new app. (sorry about that)

If this PR has changes to the content of guides please raise a PR to https://github.com/ember-learn/guides-source. If the change is to the guides viewer (i.e., the app) then please raise a PR in https://github.com/ember-learn/guides-app/. The READMEs and contributing.md guidelines of those projects will familiarize you with the new process. Let us know if you have any questions!

PS: this is a standard msg we're using across such PRs