Draft for promises #2317
Draft for promises #2317
Conversation
|
Hi @karan-pathak ! This is awesome 😄 I see a few typos and small grammar things - is it ok if I add a commit to your PR, or would you rather that I send them to you and you can make the changes? |
source/getting-started/js-primer.md
Outdated
| ```javascript | ||
| store.findRecord('person', 1).then(function(person) { | ||
|
|
||
| store.findRecord('post', 1) //query for another record. |
There was a problem hiding this comment.
If I'm understanding correctly this example, shound't this line have return so the next then would receive the returned value, in this case post?
There was a problem hiding this comment.
@josemarluedke yes, you are correct. Thanks for the observation. I've made changes to the example, and added some explanation, can you review it again?
|
Hi @jenweber, Thanks for reviewing it! please feel free to make changes to this PR, and if you want me to make the changes then just let me know :) |
|
@karan-pathak take a look and let me know what you think of my edits! After looking at this more closely, I think it needs 2 more points:
I am also going to ping @locks and/or @jaredgalanis for review. Promises are hard so some more feedback would be good. |
|
@jenweber, great edits! The extra points that you suggested seem valid. I'll add them to this PR. Also, more feedback is always welcome :) |
|
Thanks for contributing @karan-pathak ! |
#2264