This repository has been archived by the owner on May 26, 2019. It is now read-only.
Search #513
Merged
Search #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2015
|
Being somewhat "ballsy" in merging this. Seems good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trek noted that the approach #481 uses will break search if the domain structure of the site changes. Rather than revert to the previous approach of having to update the version number before building (#499), which adds an extra step and thus increases the odds of deploying a build with broken search, this PR simply adds a placeholder string for the version number, which then the
publish-searchtask of https://github.com/emberjs/guides.emberjs.com can replace with the version number of the snapshot being deployed (see emberjs/guides.emberjs.com#9).