Skip to content

Commit

Permalink
Update wording in PR templates to clarify checklist and that PRs to
Browse files Browse the repository at this point in the history
advance will open automatically
  • Loading branch information
kategengler committed Nov 22, 2022
1 parent 75cb9b3 commit 7102e36
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 7 deletions.
10 changes: 6 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ This pull request is advancing the RFC to the [Ready For Release Stage](https://

**An FCP is required before merging this PR to advance.**

Upon merging this PR, automation will open a draft PR for this RFC to move to the [Released Stage](https://github.com/emberjs/rfcs#released).

<details>
<summary>Ready for Release Stage Description</summary>
Expand All @@ -23,13 +24,14 @@ An FCP is required to move into this stage.
Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.
</details>

## Actions
## Checklist to move to Ready for Release

- [ ] Implementation is complete according to plan outlined in the RFC
- [ ] Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
- [ ] Any necessary learning materials have been updated
- [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature
- [ ] Criteria for moving to Recommended Stage has been filled out
- [ ] Each [team](https://github.com/emberjs/rfcs#relevant-teams) has been added as a reviewer to the PR and approved.
- [ ] Criteria for moving to the Recommended Stage has been filled out
- [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP
- [ ] Each [team](https://github.com/emberjs/rfcs#relevant-teams) has been added as a reviewer to the PR at the start of the FCP
* [ ] Framework @emberjs/framework
* [ ] Data @emberjs/ember-data-core
* [ ] CLI @emberjs/cli
Expand Down
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,15 @@ Any criteria for "Recommended" for this proposal that were established in the Re
An FCP is required to enter this stage. Multiple RFCs may be moved as a batch into "Recommended" with the same PR.
</details>

## Actions
## Checklist to move to Recommended

- [ ] Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met
- [ ] If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
- [ ] If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
- [ ] If the proposal updates or replaces an existing feature, high-quality codemods are available
- [ ] If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
- [ ] If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
- [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP

## Criteria for moving to Recommended (required)

Expand Down
6 changes: 4 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE/advance-to-released.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ This pull request is advancing the RFC to the [Released Stage](https://github.co
- PR to Accepted Stage: #__RFC_NUMBER__
- [PR to Ready For Release Stage](__READY_FOR_RELEASE_PR__)

Upon merging this PR, automation will open a draft PR for this RFC to move to the [Recommended Stage](https://github.com/emberjs/rfcs#recommended).

<details>
<summary>Released Stage Summary</summary>

Expand All @@ -19,8 +21,8 @@ Ember's RFC process can be used for process and work plans that are not about co
An RFC is moved into "Released" when the above is verified by consensus of the relevant team(s) via a PR to update the stage.
</details>

## Actions
## Checklist to move to Released

- [ ] The work is published in stable versions of the relevant package(s)
- [ ] Deviations from the original RFC are noted at the top of the RFC
- [ ] Deviations from the original RFC are noted in the RFC
- [ ] Release packages and dates are updated in the RFC frontmatter

0 comments on commit 7102e36

Please sign in to comment.