Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Staging #649

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Deprecation Staging #649

merged 6 commits into from
Aug 14, 2020

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Jul 24, 2020 •
edited
Loading

Thanks for @pzuraq,@rwjblue, @wycats, and the rest of the strike team for fleshing out these ideas and letting me play scribe!

rendered

@amyrlam amyrlam mentioned this pull request Jul 24, 2020
Merged
28 tasks
@rwjblue
Copy link
Member

rwjblue commented Jul 24, 2020

Thanks for working on this @mehulkar!

@rwjblue rwjblue added the T-framework RFCs that impact the ember.js library label Jul 24, 2020
@rwjblue
Copy link
Member

rwjblue commented Jul 24, 2020

Just FYI we discussed this at today's core team meeting. Nothing really to report (I don't think most folks have had a chance to review yet), but folks were excited about the progress. 😸

@camerondubas
Copy link

Nice! I don't have much to add here, although I think this is a nice progression of the deprecation system.

Could the rendered link be added to the PR description? Thanks!

@rwjblue
Copy link
Member

rwjblue commented Jul 31, 2020

@camerondubas - Yep, thanks for pointing that out!

@rwjblue
Copy link
Member

rwjblue commented Jul 31, 2020

We chatted about this today in the core team meeting. The team is very happy with the overall design and we are eager to move forward. The one area that was still a bit of a concern was around the stage names. We are pretty happy with available but there was some back and forth about the required name. After we went back and forth a bit, we'd like to change required to enabled. Other than that one change, I think we are collectively very 👍 and would like to move forward!

@mehulkar
Copy link
Contributor Author

🥳 great to hear! Enabled seems good to me too, I've updated the text.

@rwjblue
Copy link
Member

rwjblue commented Aug 7, 2020

Thanks for updating that @mehulkar! We discussed this in the most recent core team meeting, and have decided to move this into final comment period.

@mehulkar mehulkar mentioned this pull request Aug 10, 2020
Closed
@rwjblue
Copy link
Member

rwjblue commented Aug 14, 2020

Chatted about this in the core team meeting today, we are still super happy with the direction forward and are ready to land this one!

@rwjblue rwjblue merged commit 3f61cac into emberjs:master Aug 14, 2020
@mehulkar mehulkar deleted the mk/deprecation-staging branch August 26, 2020 18:36
@mehulkar mehulkar mentioned this pull request Sep 8, 2020
Merged
mehulkar pushed a commit to mehulkar/ember.js that referenced this pull request Oct 7, 2020
Add for and since options to depreacte() function
1f420ce 
This implements the first stage of the Deprecation Staging RFC
emberjs/rfcs#649

This commit also:

- deprecates the usage of deprecate() function without passing
these options
- Updates all the usages of deprecate() in the repo to pass
these options.
@pzuraq pzuraq mentioned this pull request Feb 3, 2021
Closed
@SergeAstapov SergeAstapov mentioned this pull request May 28, 2021
Merged
@igorT igorT mentioned this pull request Aug 2, 2021
Merged
@emberjs-rfcs-bot emberjs-rfcs-bot mentioned this pull request Jan 12, 2023
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees

@rwjblue rwjblue

@pzuraq pzuraq

Labels
Final Comment Period T-framework RFCs that impact the ember.js library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehulkar @rwjblue @camerondubas @pzuraq