Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First-Class Component Templates #779

Merged
merged 59 commits into from
Mar 4, 2022
Merged

First-Class Component Templates #779

merged 59 commits into from
Mar 4, 2022

Commits on Dec 3, 2021

  1. RFC: First-Class Component Templates

    @chriskrycho
    chriskrycho committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    68a7c62 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded comments, add a drawback I missed

    @chriskrycho
    chriskrycho committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    c599c05 View commit details
    Browse the repository at this point in the history

  3. Update the TOC with final outline

    @chriskrycho
    chriskrycho committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    eab0514 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2021

  1. Fix some missing content

    @chriskrycho
    chriskrycho committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    39d5e72 View commit details
    Browse the repository at this point in the history

  2. Remove text about Svelte RFC duration

    @chriskrycho
    chriskrycho committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    7b2d25d View commit details
    Browse the repository at this point in the history

  3. Fix a wordo

    @chriskrycho
    chriskrycho committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    9174157 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. Fix typos, grammatical errors, and wrong assertions 

    Thanks to the reviewers who spotted these!

Co-authored-by: Alon Bukai <alonzorz@gmail.com>
Co-authored-by: Bert De Block <bert.deblock@bagaar.be>
Co-authored-by: David Baker <acorncom@users.noreply.github.com>
    @chriskrycho @Alonski
    @bertdeblock @acorncom
    4 people authored Dec 5, 2021
    Configuration menu
    Copy the full SHA
    e4e8927 View commit details
    Browse the repository at this point in the history

  2. Fix two code samples 

    - remove a needless use of `modifier()`
- remove extraneous imports
    @chriskrycho
    chriskrycho committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    c322cdc View commit details
    Browse the repository at this point in the history

  3. Improve presentation of imports-only discussion

    @chriskrycho
    chriskrycho committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    028f3be View commit details
    Browse the repository at this point in the history

  4. Add note about component names in blueprint

    @chriskrycho
    chriskrycho committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    808cba4 View commit details
    Browse the repository at this point in the history

  5. Include helper and modifier in prelude helpers

    @chriskrycho
    chriskrycho committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    11d290e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Clarify a number of points throughout

    @chriskrycho
    chriskrycho authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    f33a32a View commit details
    Browse the repository at this point in the history

  2. Clarify intro of classes and fix a typo

    @chriskrycho
    chriskrycho authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    2c0fbe5 View commit details
    Browse the repository at this point in the history

  3. Update TOC with newly added section

    @chriskrycho
    chriskrycho committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    53e8b8d View commit details
    Browse the repository at this point in the history

  4. Improve discussion of compilation and static scope

    @chriskrycho
    chriskrycho committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    d9df94a View commit details
    Browse the repository at this point in the history

  5. Improve summary, standardize on 'first-class'

    @chriskrycho
    chriskrycho committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    5e56ae4 View commit details
    Browse the repository at this point in the history

  6. Fix typo and phrasing

    @chriskrycho
    chriskrycho committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    1f8e104 View commit details
    Browse the repository at this point in the history

  7. Present top-level/default export first 

    This clarifies the motivation for introducing that form, and shows
how locally-scoped components build on top of it.
    @chriskrycho
    chriskrycho committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    8f7cac2 View commit details
    Browse the repository at this point in the history

  8. 'Drawbacks' was covering platform <template> twice

    @chriskrycho
    chriskrycho committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    91894f7 View commit details
    Browse the repository at this point in the history

  9. Fix a few code samples

    @chriskrycho
    chriskrycho authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    66adea1 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Add discussion of non-colocated templates, codemod

    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    21096fc View commit details
    Browse the repository at this point in the history

  2. Add recommendation and discussion of template types 

    As part of the addition, also include a discussion of the possibility of
using `<component>` alongside `<template>`, and describe the tradeoffs
with `hbs` for type signatures as well.
    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    16a8b75 View commit details
    Browse the repository at this point in the history

  3. Acknowledge no-two-files drawback

    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    e042883 View commit details
    Browse the repository at this point in the history

  4. Fix an incomplete sentence

    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    673b248 View commit details
    Browse the repository at this point in the history

  5. Drop reference to since-removed footnote

    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    eb836e5 View commit details
    Browse the repository at this point in the history

  6. E_TOO_MANY_EM_DASHES

    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    afa244b View commit details
    Browse the repository at this point in the history

  7. Fix hbs TS tradeoff 

    Note: if this confused *me* this much, I cannot imagine how bad the
confusion would be for people with massively less context.
    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8f87cd4 View commit details
    Browse the repository at this point in the history

  8. Fix a bunch of typos

    @chriskrycho
    chriskrycho committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    831cc40 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Include reference to RFC 0432

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    5990a04 View commit details
    Browse the repository at this point in the history

  2. Just reference RFC 0496 for prelude and keywords

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    e81782e View commit details
    Browse the repository at this point in the history

  3. Clarify linting

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    1301851 View commit details
    Browse the repository at this point in the history

  4. Extract discussion of performance into dedicated section

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d8fdd35 View commit details
    Browse the repository at this point in the history

  5. Fix a typo in a code sample

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    f00eab4 View commit details
    Browse the repository at this point in the history

  6. Include isStrict: true

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3fa537d View commit details
    Browse the repository at this point in the history

  7. Clarify private class fields handling

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    c1ead82 View commit details
    Browse the repository at this point in the history

  8. Clarify why named exports aren't resolvable in loose mode

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    556e9e0 View commit details
    Browse the repository at this point in the history

  9. Add section on custom file extension

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    b460e4b View commit details
    Browse the repository at this point in the history

  10. Clarify which blueprints to update, what to do

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ea79273 View commit details
    Browse the repository at this point in the history

  11. Link to Rust's prelude docs in footnote

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    39f9c90 View commit details
    Browse the repository at this point in the history

  12. Discuss default component manager option

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    2541525 View commit details
    Browse the repository at this point in the history

  13. Add 'Transition' section

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d1d4082 View commit details
    Browse the repository at this point in the history

  14. Fix: isStrict -> strictMode

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3dbd51f View commit details
    Browse the repository at this point in the history

  15. Further clarify open question on default component manager

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    6284bca View commit details
    Browse the repository at this point in the history

  16. Another fix around let: legal but reassignment useless

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d3b32c0 View commit details
    Browse the repository at this point in the history

  17. Some useful parentheses

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ed79e13 View commit details
    Browse the repository at this point in the history

  18. Sentence redundancy yooooo

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    5b77dee View commit details
    Browse the repository at this point in the history

  19. Clarity on uses of <template> in functions

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    8aae383 View commit details
    Browse the repository at this point in the history

  20. A missing strict mode

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    fdceb29 View commit details
    Browse the repository at this point in the history

  21. Add footnote on deprecating non-colocated components

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    42408ab View commit details
    Browse the repository at this point in the history

  22. Add note about 'template-only' language

    @chriskrycho
    chriskrycho committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ed5e12a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2021

  1. Fix incomplete sentence

    @chriskrycho
    chriskrycho committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    39d8814 View commit details
    Browse the repository at this point in the history

  2. Elaborate 'Transition path' 

    No new information in this, just summarizing it all in once place
    @chriskrycho
    chriskrycho committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    e92a8bb View commit details
    Browse the repository at this point in the history

  3. Fix a bad transition (left over from previous structure)

    @chriskrycho
    chriskrycho committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    828c878 View commit details
    Browse the repository at this point in the history

  4. Improve discussion of named exports workaround

    @chriskrycho
    chriskrycho committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    585bc83 View commit details
    Browse the repository at this point in the history

  5. Slight improvement to paragraph on Mapbox/helpers

    @chriskrycho
    chriskrycho committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    0f1ec07 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Add reference to emberjs#785 now that it is published 

    Instead of 'forthcoming RFC', link directly to emberjs#785!
    @chriskrycho
    chriskrycho authored Jan 8, 2022
    Configuration menu
    Copy the full SHA
    c1b4bee View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Add note on plan for Spec

    @chriskrycho
    chriskrycho committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    630c970 View commit details
    Browse the repository at this point in the history

  2. Fix a typo

    @chriskrycho
    chriskrycho committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    3e9a541 View commit details
    Browse the repository at this point in the history

  3. Update TOC

    @chriskrycho
    chriskrycho committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    5f8ff4c View commit details
    Browse the repository at this point in the history