Update RFC 496, typos, use correct field name (strict => strictMode) #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all the implementations of strict-mode stuff use
strictMode
, rather than juststrict
(that I could find)
ember-template-imports, here:
ember-source:
The
<template>
RFC: https://github.com/emberjs/rfcs/pull/779/files#diff-9a7c2cf97ea750d29eb74c905ba69631d23b9f30f868d93ec9746f30840cfaa6R330@glimmer/compiler
: https://github.com/glimmerjs/glimmer-vm/blob/master/packages/%40glimmer/compiler/lib/compiler.ts#L124I thought it'd be easier to update this RFC than to update all the implementations to use
strict
instead ofstrictMode
-- also felt like it'd be the stabler option, as gjs/gts is presently emitted withstrictMode