Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service methods and method injection #98

Closed
wants to merge 1 commit into from

Conversation

tim-evans
Copy link

Rendered

This RFC is an evolution of #71 that piggy backs on Ember Services.
This is implemented as an addon: https://github.com/tim-evans/ember-service-methods

@tim-evans
Copy link
Author

tim-evans commented Feb 14, 2017

I think I'm going to close this due to inactivity if there's no action to take on this. :)

@DingoEatingFuzz
Copy link

As far as code management, we use modules for these types of functions. You don't get DI that way, but we have gotten away with mocking services and using Pretender for testing.

@tim-evans
Copy link
Author

tim-evans commented Feb 14, 2017

@DingoEatingFuzz yeah, I was using those as well for a bit of code management as well, but it became a mess when the store was suddenly required.

I have a bunch of examples in this folder for a variety of service methods:

https://github.com/tim-evans/queertangoclub/tree/master/app/services

Creating an expense and attaching a photo to it is one of the better examples. Also, encapsulating a whole big ball of mess into the save method was helpful, if possibly misguided.

@tim-evans
Copy link
Author

Closing due to inactivity :)

@tim-evans tim-evans closed this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants