-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 addon by default #985
base: master
Are you sure you want to change the base?
v2 addon by default #985
Conversation
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
text/0985-v2-addon-by-default.md
Outdated
|
||
## Detailed design | ||
|
||
`@embroider/addon-blueprint` will remain its own repo. `ember addon` will use this by default without a flag at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of note, ember-cli 5.4 broke the @embroider/addon-blueprint
.
So, that's the biggest risk with using an external blueprint with no other changes to process.
The details of flags of how blueprints are created (packageManager
in this case vs yarn
or npm
flags) don't feel exactly like public API, so I'm sure that makes this more complicated.
`@embroider/addon-blueprint` has been in progress for a while, it's good stuff. | ||
|
||
|
||
## Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
motivation for having external blueprint, rather than built in to ember-cli?
- easiest to test
- ember-cli's test suite is already quite slow (due to tons of tests)
- can be independently versioned, patched, etc
## Detailed design | ||
|
||
`@embroider/addon-blueprint` will remain its own repo. `ember addon` will use this by default without a flag at some point. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the addon-blueprint would likely need to test against a range of ember-cli versions, rather than what it does today, which is always use latest.
this would be good to do anyway (today) as it gives us a solid understanding of what is supported.
Afaik, the minimum supported ember-cli must be at least 5.3 for full typescript support -- the v2 addon blueprint has been ahead of ember-cli in this area for a bit, but in 5.3 alignment occurred and we don't want to have incoherence between the v2 addon blueprint and the generated app blueprint that's used for the test-app in the v2 addon blueprint as that is still under ember-cli's control
text/0985-v2-addon-by-default.md
Outdated
|
||
## How we teach this | ||
|
||
> What names and terminology work best for these concepts and why? How is this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, we'll need ember-cli to formally allow blueprints to implement their own flags
Would like to codify a testing story where Ember used as library without having to have a separate app. |
No description provided.