Correct error message to tell me to use #sideload, not #reloadWith

[muziejus]

probably something that will get fixed once reloadWith goes away, but I got this error today having only ever known sideload and was rather confused about this "new" method I'd never heard of.

[ryanto]

Too many redirects :D

Thanks for the PR! 👍

[ryanto]

Hey @muziejus - Looks like our master branch had a problem that's causing your tests to fail! It's fixed now, so could you rebase/pull in master? That should get your test suite passing.

Sorry about that!

[muziejus]

11pm is maybe not the best time to remind myself how to do a rebase, but I think I finally stopped just recommitting everything over and over. Hopefully the morning will bring clarity.

[muziejus]

Nevertheless, I'm getting pretty fundamental errors on yarn test:all like (in ember lts 2.12 scenario):

Environment: test
(node:85640) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "node_modules/eslint-plugin-ember/lib/config/base.js")
'ember-inflector' is imported by -private/build-url-mixin.js, but could not be resolved – treating it as an external dependency
[BABEL] Note: The code generator has deoptimised the styling of /Users/moacir/Projects/ember-data-storefront/node_modules/lodash/lodash.js as it exceeds the max of 500KB.
cleaning up...
Built project successfully. Stored in "/Users/moacir/Projects/ember-data-storefront/tmp/class-tests_dist-5MnKgpKc.tmp".
not ok 1 Chrome 75.0 - [undefined ms] - Global error: Uncaught Error: Could not find module `ember` imported from `ember-data/index` at http://localhost:7357/assets/vendor.js, line 252
    ---
        browser log: |
            testContext: [object Object]
            ERROR: Uncaught Error: Could not find module `ember` imported from `ember-data/index` at http://localhost:7357/assets/vendor.js, line 252

    ...
not ok 2 Chrome 75.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: The tests file was not loaded. Make sure your tests index.html includes "assets/tests.js". at http://localhost:7357/assets/vendor.js, line 16939
    ---
        browser log: |
            testContext: [object Object]
            ERROR: Uncaught Error: Assertion Failed: The tests file was not loaded. Make sure your tests index.html includes "assets/tests.js". at http://localhost:7357/assets/vendor.js, line 16939

    ...

And now both the tests on my computer and travis seem to be hanging. I thought at first I was doing something wrong, but this is w/ a fresh yarn install.

[ryanto]

Yikes! Your latest rebase looks good, so I'm guessing the tests will pass on CI.

Generally when I'm working on this addon I'll only run ember test. If that passes I'll push up to github and debug the try scenarios only if they fail in CI.

Getting yarn test:all to work locally might be too slow and finicky. Happy to help you debug if CI starts failing, but lets not cross that bridge until we need to :)

[ryanto]

And now both the tests on my computer and travis seem to be hanging.

Travis is getting busy and blocked by dependabot PRs right now. They usually takes all night, especially since we queued up a fresh batch earlier. I've noticed when that happens travis rate limits the test runs for this repo. Let's let it run all night and what it says in the morning.

[muziejus]

Thanks. I have 0 familiarity w/ contributing to addons, so I only understand things like ember-try and whatever half-conceptually.