Fix macOS can't connect because of an error 400

[glhaynes]

Return the correct value for EMBDevice.operatingSystemVersion when on macOS. Fixes an issue where macOS Embrace can't connect because of an error 400:

{
  "error": {
    "msg": "Missing required parameter: appVersion",
    "code": 1
  }
}

[atreat]

Thanks for the PR 👍. We'll be sure to include this in a future release

[atreat]

Hey @glhaynes, before we pull this in - Would you mind taking a look at our (newly added) contributing guidelines? Specifically, would you mind reading through and agreeing to the Individual Contributor License Agreement (CLA).

We really appreciate the contribution and the testing you've done for this project in its early stages!

[glhaynes]

Hi, @atreat! Excited for y'all to include this little fix. I get this when I click on both of those links, though:

You need permission
This form can only be viewed by users in the owner's organization.

[atreat]

@glhaynes That's on me, I accidentally pasted the same link twice. The contributing guidelines link should be updated. It is also found in the repo at .github/CONTRIBUTING.md (on the main branch). I also had the Google form link for the CLA updated to be public.

Let me know if you have chance to look through these. Thank you!

[glhaynes]

Done. Thanks!

[atreat]

We pulled this in! Going to close this as it is now on main and part of our 6.0.0-beta release!

embrace-apple-sdk/Sources/EmbraceObjCUtils/source/EMBDevice.m

Lines 335 to 343 in 00109f3

	+ (NSString *)operatingSystemVersion
	{
	NSOperatingSystemVersion operatingSystemVersion = [NSProcessInfo processInfo].operatingSystemVersion;
	if (operatingSystemVersion.patchVersion == 0) {
	return [NSString stringWithFormat: @"%i.%i", (int)operatingSystemVersion.majorVersion, (int)operatingSystemVersion.minorVersion];
	} else {
	return [NSString stringWithFormat: @"%i.%i.%i", (int)operatingSystemVersion.majorVersion, (int)operatingSystemVersion.minorVersion, (int)operatingSystemVersion.patchVersion];
	}
	}

We liked this implementation and preferred to remove the UIKIT_AVAILABLE check entirely! I made sure to add some tests around this as I realized we had not setup a proper test target for our ObjCUtils. Really appreciate the contribution! You're officially on the list of contributors! Thanks a bunch @glhaynes

[glhaynes]

Oh, great point, it didn't cross my mind that those would be equally available on iOS!

Happy to help, excited to see this in beta as we're looking forward to adopting it.