Update README #11
Merged
Update README #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
santileira
reviewed
Jun 20, 2024
README.md
Outdated
| @@ -62,14 +73,14 @@ func main() { | |||
| "retention-days": "14", | |||
| }) | |||
| if err != nil { | |||
| panic("unable to create temp file: " + err.Error()) | |||
| panic("failed to create temp file: " + err.Error()) | |||
| } | |||
|
|
|||
| // Append all the objects to the file: | |||
| for id, obj := range objects { | |||
| err = file.Append(id, obj) | |||
| if err != nil { | |||
There was a problem hiding this comment.
I would do:
if err := file.Append(id, obj); err != nil {
panic(.....)
}
santileira
approved these changes
Jun 20, 2024
fnewberg
approved these changes
Jun 20, 2024
| is placed in the file, and then upload one single file to s3 with many objects in it, reducing drastically the number | ||
| of PUT operations needed to store a large number of objets. | ||
|
|
||
| Then, when you need to retrieve an object, you can use the index information to fetch that object and the GET call to s3 |
There was a problem hiding this comment.
should we add something about storing on the index data being beyond the scope of what this repo does, e.g.
The best solution for how to store and query your index data will depend on your application data patterns and is beyond the scope of what this package aspires to do.
There was a problem hiding this comment.
good point, will add!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a better description of why this module might be useful and in which cases.