Specify full golang toolchain version #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeQL is [warning](https://github.com/embrace-io/s3-batch-object-store/security/code-scanning/tools/CodeQL/status/configurations/automatic) about: > As of Go 1.21, toolchain versions [must use the 1.N.P syntax](https://go.dev/doc/toolchain#version). > 1.22 in go.mod does not match this syntax and there is no additional toolchain directive, which may cause some go commands to fail.
pablomatiasgomez
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Interesting that this is working now, when I tested this a few commits ago, I got an error from GHA https://github.com/embrace-io/s3-batch-object-store/actions/runs/9319220557/job/25653261726 Maybe it was because at that point I was using actions/setup-go@v4 and now we are in v5.
|
In that build you were compiling using go 1.20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL is warning about: