Add optional parameter to specify type of animation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default animations on
TreeViewandSliverTreeViewwork fine for small lists, but they break down with a large number of complex elements. This PR proposes an optionalAnimation<double>? animationparameter for each of them (as well as each of their respective constructors) that allows users to specify a custom animation, including suppressing animation altogether.Omitting the
animationparameter defaults animation to the package default, so this PR introduces no breaking changes.I've also added an optional
durationparameter toscrollToItemandscrollToIndexthat defaults to the library default.(Also—this is a feature born purely of self interest. I've got a big tree I'm trying to manage, and this library is perfect for my use case except that the thing freaks out when it tries to animate.)