Skip to content

Commit

Permalink
Merge pull request #277 from embroider-build/NullVoxPopuli-patch-3
Browse files Browse the repository at this point in the history
 Because TS addons need to emit declarations, we need to set noEmit to false
  • Loading branch information
ef4 authored Mar 26, 2024
2 parents 7ef6a30 + 570bd32 commit 8b7e2be
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions files/__addonLocation__/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,25 @@
"compilerOptions": {
"allowJs": true,
"declarationDir": "declarations",
/**
https://www.typescriptlang.org/tsconfig#noEmit
We want to emit declarations, so this option must be set to `false`.
@tsconfig/ember sets this to `true`, which is incompatible with our need to set `emitDeclarationOnly`.
@tsconfig/ember is more optimized for apps, which wouldn't emit anything, only type check.
*/
"noEmit": false,
/**
https://www.typescriptlang.org/tsconfig#emitDeclarationOnly
We want to only emit declarations as we use Rollup to emit JavaScript.
*/
"emitDeclarationOnly": true,

/**
https://www.typescriptlang.org/tsconfig#noEmitOnError
Do not block emit on TS errors.
*/
"noEmitOnError": false,

/**
https://www.typescriptlang.org/tsconfig#rootDir
Expand Down

0 comments on commit 8b7e2be

Please sign in to comment.