Skip to content

Commit

Permalink
Run tests with latest Ember CLI
Browse files Browse the repository at this point in the history
Use canary version of ember-cli on master branch, until we ge get a stable/beta release on npm, which includes better support of `--typescript` ([PR](ember-cli/ember-cli#10283)). Cleans up previous weirdness.
  • Loading branch information
simonihmig committed Jul 5, 2023
1 parent 8089520 commit d048079
Show file tree
Hide file tree
Showing 5 changed files with 1,886 additions and 2,109 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,22 @@ jobs:
# waiting on a an api from vitest for querying
# the list of tests ahead of time before running them.
#
# It would be great if vitest had a flag to give us the JSON of all the tests,
# so we could be sure we don't miss anything
# It would be great if vitest had a flag to give us the JSON of all the tests,
# so we could be sure we don't miss anything
# and then generate this list from a previous C.I. job
slow-test:
- defaults with npm
- defaults with yarn
- defaults with pnpm

# TypeScript
- typescript with npm
- typescript with yarn
- typescript with pnpm

# flags
- addon-location
- test-app-location
- typescript
- addon-only

# existing monorepo
Expand Down
5 changes: 5 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,17 @@ module.exports = {

if (options.typescript) {
const needsVersion = '4.9.0-beta.0';
const recommendedVersion = '5.2.0-beta.0';
const hasVersion = this.project.emberCLIVersion();

if (lt(hasVersion, needsVersion)) {
this.ui.writeWarnLine(
`Your version ${hasVersion} of Ember CLI does not support the --typescript flag yet. Please run \`ember install ember-cli-typescript\` in the ${testAppInfo.location} folder manually!`
);
} else if (lt(hasVersion, recommendedVersion)) {
this.ui.writeWarnLine(
`We recommend using Ember CLI >= ${recommendedVersion} for the best blueprint support when using TypeScript!`
);
}
}
},
Expand Down
Loading

0 comments on commit d048079

Please sign in to comment.