Updated the addon package's Babel configuration #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
May 31, 2023
| @@ -1,9 +1,9 @@ | |||
| { | |||
| <% if (typescript) { %> "presets": [["@babel/preset-typescript"]], | |||
| <% } %> "plugins": [<% if (typescript) { %> | |||
| <% } %> "plugins": [ | |||
| "@embroider/addon-dev/template-colocation-plugin",<% if (typescript) { %> | |||
There was a problem hiding this comment.
I upstreamed the interpolation code from ember-codemod-v1-to-v2. The expected output can be seen in these tests:
ijlee2
commented
May 31, 2023
| @@ -33,7 +33,6 @@ | |||
| <% if (typescript) { %>"@babel/preset-typescript": "^7.18.6"<% } else { %>"@babel/eslint-parser": "^7.19.1"<% } %>, | |||
| "@babel/plugin-proposal-class-properties": "^7.16.7", | |||
| "@babel/plugin-proposal-decorators": "^7.20.13", | |||
| "@babel/plugin-syntax-decorators": "^7.17.0", | |||
There was a problem hiding this comment.
To my knowledge, @babel/plugin-syntax-decorators is unused in a v2 addon and is not needed according to Babel.
Syntax only
It's unlikely you want to use this plugin directly as it only enables Babel to parse this syntax. Instead, use plugin-proposal-decorators to both parse and transform this syntax.
ijlee2
commented
May 31, 2023
| ["@babel/plugin-transform-typescript", { "allowDeclareFields": true }],<% } %> | ||
| "@embroider/addon-dev/template-colocation-plugin", | ||
| ["@babel/plugin-proposal-decorators", { "decoratorsBeforeExport": true }], | ||
| ["@babel/plugin-proposal-decorators", { "version": "legacy" }], |
There was a problem hiding this comment.
I tested { "version": "legacy" } with ember-container-query as well as 4 private addons. The tests for these addons passed.
|
Thank you! |
gilest
added a commit
to adopted-ember-addons/ember-file-upload
that referenced
this pull request
Jun 9, 2023
Continuation of #938 now that I've found a configuration which allows builds to succeed on CI. Believe the underlying issue is with rollup-plugin-ts as explained here: babel/babel/issues/15670 Also mentioned in passing here: embroider-build/addon-blueprint/pull/127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I introduced a few changes to the Babel configuration for v2 addons:
Changed the default option for
@babel/plugin-proposal-decoratorsto{ "legacy": true }(to address a bug), then to{ "version": "legacy" }(to address a deprecation)Reordered the plugins to group Babel plugins together
Removed
@babel/plugin-syntax-decorators(unused) frompackage.jsonThe latter two code changes may be considered new to
@embroider/addon-blueprint. I've created and used v2 addons with these changes for about 3 months, so I think we can consider the changes safe to implement.Notes
The failing status check
Tests (typescript), with the error messageCannot find module '@babel/plugin-proposal-object-rest-spread', is unrelated to this pull request.I encountered the error message while trying to update the dependencies of
ember-container-query(failed in #194, then later succeeded in #196 and #197).According to babel/babel#15670 (comment), the issue might have been caused by
rollup-plugin-tsnot declaring@babel/plugin-proposal-object-rest-spreadas a dependency or peer dependency.