Update for ember-cli --typescript changes
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
commented
Jul 3, 2023
| @@ -4,7 +4,8 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app'); | |||
|
|
|||
| module.exports = function (defaults) { | |||
| let app = new EmberApp(defaults, { | |||
| autoImport: { | |||
| <% if (typescript) {%>'ember-cli-babel': { enableTypeScriptTransform: true }, | |||
There was a problem hiding this comment.
|
Successfully tested locally, CI failing due to #133 |
NullVoxPopuli
approved these changes
Jul 3, 2023
Update our blueprint to take account of changes when generating the test-app with `--typescript` ([PR](ember-cli/ember-cli#10283)). The new blueprint now drops ember-cli-typescript and opts into the TS transform of ember-cli-babel, which we must not override.
simonihmig
force-pushed
the
update-for-upstream-ts-changes
branch
from
0d5e18d
to
65dc56d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our blueprint to take account of changes when generating the test-app with
--typescript(PR). The new blueprint now drops ember-cli-typescript and opts into the TS transform of ember-cli-babel, which we must not override.