Reproduce issue described in #45 - multi-byte characters are counted incorrectly. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Dec 14, 2023
| @@ -37,6 +37,37 @@ describe("parse", function () { | |||
| ]); | |||
| }); | |||
|
|
|||
| it("multi-byte characters", function () { | |||
| let contentLength = "안녕하세요 세계".length; | |||
There was a problem hiding this comment.
I defined all these lengths here because I can't count myself
NullVoxPopuli
commented
Dec 14, 2023
| type: "expression", | ||
| tagName: "template", | ||
| contents: "안녕하세요 세계", | ||
| range: { |
There was a problem hiding this comment.
a range is always [start, end), just like String.prototype.slice
[inclusive, exclusive) or, from the frame of reference of the substring-in-question: [start index, index one character immediately after)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-byte characters are counted incorrectly.
or
Rust and JS count string length differently 🙃
(at which point, our JS offset output is a bit misleading, because we don't exactly communicate that the ranges are byte offsets, and it's not super straight forward to convert from byte offsets to char offsets in JS)