Skip to content

Commit

Permalink
Merge pull request #1233 from NullVoxPopuli/hoist-transitive-imports
Browse files Browse the repository at this point in the history
Default hoistTransitiveImports to false
  • Loading branch information
ef4 authored Jul 21, 2022
2 parents 0ce58c5 + a74cd70 commit f00c88d
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion packages/addon-dev/src/rollup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,18 @@ export class Addon {
// emitting ES modules, in your `destDir`, and their filenames are equal to
// their bundle names (the bundle names get generated by `publicEntrypoints`
// above).
//
// hoistTransitiveImports is disabled because the purpose of hoisting transitive imports
// is to improve performance of apps loading modules.
// Since v2 addons do not know exactly how they'll be used, this performance decision
// is left up to apps.
output() {
return { dir: this.#destDir, format: 'es', entryFileNames: '[name]' };
return {
dir: this.#destDir,
format: 'es',
entryFileNames: '[name]',
hoistTransitiveImports: false,
};
}

dependencies() {
Expand Down

0 comments on commit f00c88d

Please sign in to comment.