add a guard to let us know if a packager loop is likely

embroider-build · Nov 16, 2023 · f53a466 · f53a466
1 parent 4c618df
commit f53a466
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/core/src/module-resolver.ts b/packages/core/src/module-resolver.ts
@@ -242,6 +242,13 @@ export class Resolver {
       // no additional fallback is available.
       return resolution;
     }
+
+    if (nextRequest.fromFile === request.fromFile && nextRequest.specifier === request.specifier) {
+      throw new Error(
+        'Bug Discovered! New request is not === original request but has the same fromFile and specifier. This will likely create a loop.'
+      );
+    }
+
     if (nextRequest.isVirtual) {
       // virtual requests are terminal, there is no more beforeResolve or
       // fallbackResolve around them. The defaultResolve is expected to know how