Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ember-engines v0.8.5+ and ember-source < 3.24 #857

Closed
thoov opened this issue Jun 16, 2021 · 3 comments · Fixed by ember-engines/ember-engines#777
Closed

Issue with ember-engines v0.8.5+ and ember-source < 3.24 #857

thoov opened this issue Jun 16, 2021 · 3 comments · Fixed by ember-engines/ember-engines#777

Comments

@thoov
Copy link
Collaborator

thoov commented Jun 16, 2021

Error:

Error: Could not find module `../components/link-to-component` imported from `(require)`
   at missingModule (http://localhost:7357/assets/vendor.js:256:11)
   at findModule (http://localhost:7357/assets/vendor.js:267:7)
   at requireModule (http://localhost:7357/assets/vendor.js:33:15)
   at Class.buildRegistry (webpack://app-template/../../home/runner/work/embroider/embroider/tests/scenarios/node_modules/ember-engines/-private/engine-ext.js?:13:98)

Relevant:

https://github.com/ember-engines/ember-engines/blob/9cf5d88d79d8ea025a291ac2b6feb6da7a16b908/packages/ember-engines/addon/-private/engine-ext.js#L14

Temp workaround:

Pin ember-engines to 0.8.5

@thoov
Copy link
Collaborator Author

thoov commented Jun 16, 2021

Found this issue during #854 when trying to unpin ember-engines version

@ef4
Copy link
Contributor

ef4 commented Jun 16, 2021

Yeah, I saw this too but didn't debug it yet: #745

@thoov
Copy link
Collaborator Author

thoov commented Jun 16, 2021

@ef4 this fixes it: ember-engines/ember-engines#777. We might want to talk about how we can handle this case better or output a warning / error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants