Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dependencySatisfies only considers actual dependencies (includes a fix for invalid results within monorepo scenarios) #1070

Merged
merged 8 commits into from
Jan 12, 2022
Merged

Ensure dependencySatisfies only considers actual dependencies (includes a fix for invalid results within monorepo scenarios) #1070

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d43b180
Do not try to resolve packages that are not declared in dependencies
NullVoxPopuli Jan 10, 2022
cf495d2
oh no, I broke everything lol
NullVoxPopuli Jan 10, 2022
498dd66
wip: debug stuff
NullVoxPopuli Jan 11, 2022
e47e4ea
refactoring the babel tests to always use an explicit project
ef4 Jan 11, 2022
7841e11
updated glimmer tests
ef4 Jan 12, 2022
05cb6bb
don't risk mutating a real copy of lodash
ef4 Jan 12, 2022
7134343
refactoring PackageCache and MacrosConfig so they reliably know where…
ef4 Jan 12, 2022
9b9fd6d
fix fast-failure in nonResolvableDeps
ef4 Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/macros/tests/babel/dependency-satisfies.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,25 @@ describe(`dependencySatisfies`, function () {
);
expect(runDefault(code)).toBe(true);
});

test('monorepo resolutions resolve correctly', () => {
NullVoxPopuli marked this conversation as resolved.
Show resolved Hide resolved
project = new Project('test-app', '1.0.0');
project.addDependency('@embroider/util', '*');
project.writeSync();

process.chdir(project.baseDir);

let code = transform(`
import { dependencySatisfies } from '@embroider/macros';

// specified in dependencies
export const util = dependencySatisfies('@embroider/util', '*');
// not specified as any kind of dep
export const webpack = dependencySatisfies('@embroider/webpack', '*');
`);

expect(code).toMatch(/util = true/);
expect(code).toMatch(/webpack = false/);
NullVoxPopuli marked this conversation as resolved.
Show resolved Hide resolved
});
});
});