Updates for LTS 3.28 including ember-data #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an Ember 3.28 LTS to the test matrix. We used to test is as "release" but now that has moved on. And in order to keep the suite the same size, I'm dropping the scenario for 3.20. We still test 3.16, our oldest supported LTS, which should give us plenty of coverage. Things that work in 3.16 and 3.24 are very unlikey to be broken in 3.20.
Windvis
reviewed
Jan 24, 2022
Co-authored-by: Sam Van Campenhout <sam.van.campenhout@gmail.com>
rwjblue
reviewed
Jan 31, 2022
| @@ -30,25 +30,25 @@ | |||
| "broccoli-persistent-filter": "^3.1.2", | |||
| "ember-bootstrap": "^4.6.3", | |||
| "ember-cli-3.16": "npm:ember-cli@~3.16.0", | |||
There was a problem hiding this comment.
I'm curious, why keep 3.16 and drop 3.20?
There was a problem hiding this comment.
Purely to keep the test suite smaller. We still support both, we're just testing the older one of the two and assuming it's unlikely that the newer one is broken if LTS releases on either side of it are working.
This closes #1112 by removing our OneShot optimization hack in favor of turning on broccoli memoization by default. Broccoli memoization should absolutely be broccoli's default. It's not yet, but we can turn the flag on here unless users have explicitly turned it off.
|
Merged #1115 into here because I suspect it will unblock the failing tests here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an Ember 3.28 LTS to the test matrix. We used to test is as "release" but now that has moved on.
And in order to keep the suite the same size, I'm dropping the scenario for 3.20. We still test 3.16, our oldest supported LTS, which should give us plenty of coverage. Things that work in 3.16 and 3.24 are very unlikey to be broken in 3.20.