-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preprocessors tree by wrapping with moduleName #1205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wondersloth
changed the title
Tree passed to preprocessors for app and addon is not scoped with moduleName
WIP Tree passed to preprocessors for app and addon is not scoped with moduleName
May 19, 2022
wondersloth
changed the title
WIP Tree passed to preprocessors for app and addon is not scoped with moduleName
Tree passed to preprocessors for app and addon is not scoped with moduleName
May 19, 2022
wondersloth
changed the title
Tree passed to preprocessors for app and addon is not scoped with moduleName
Fix preprocessors tree by wrapping with moduleName
May 19, 2022
wondersloth
commented
May 19, 2022
wondersloth
commented
May 19, 2022
wondersloth
commented
May 19, 2022
wondersloth
force-pushed
the
FIX-preprocessors
branch
from
May 19, 2022 18:51
b370bfe
to
5316f55
Compare
@ef4 I've got my tests for the preprocessors to pass. FWIW the entire test suite passes for Next would be to validate this more broadly. |
In my integration testing with the example apps in ember-css-modules, I found another bug.
|
wondersloth
force-pushed
the
FIX-preprocessors
branch
from
May 26, 2022 19:57
2b53658
to
4e4d81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
Replicated the issue here:
https://github.com/wondersloth/demo-embroider-preprocessors-bug
In a classic build the tree passed to the preprocessor is scoped with the moduleName.
In embroider, th app or addon tree is not scoped with the name/moduleName
This creates backcompat issues with addons like
ember-css-modules
that uses the file path to generate hash for some values. Initial attempt fixing from an addon.yarn link @embroider/compat
indemo-embroider-preprocessors-bug
v1-app.ts
to scope/wrap with moduleName when passing to preprocessors.my-addon
.