Dropping support for older ember's #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaking release will apply to the core and compat packages. We don't need breaking releases to macros, util, etc. |
ef4
force-pushed
the
drop-unuspported-embers
branch
from
02f914c to
cd1306b
Compare
ef4
force-pushed
the
drop-unuspported-embers
branch
from
b771ba8 to
a1585b9
Compare
ef4
added a commit
that referenced
this pull request
Aug 17, 2022
Rebuilds could crash on windows when working with a v1 addon's dummy app. We already defend against the weird circularity of dummy apps, but the check didn't work on windows. This has test coverage that will land as part of #1246, because that includes a refactor of the test suite that reveals this problem.
ef4
added a commit
that referenced
this pull request
Aug 17, 2022
When an addon does app.import of a file out of node_modules, the path we use to refer to that file had a mix of different path separators. That doesn't actually break, but the inconsistency made it hard to test and our test suite revealed the problem (in #1246).
This was trying to standardize relocatedFiles to always have unix path separators, but when it's actually consumed we're comparing with OS-specific path separators.
This was incorrect, we already have standardized paths where this gets used.
|
There is more to do here but this has now completed the refactor of the test suite, which resulted in fixing a bunch of windows bugs, and this branch is huge, so I'm merging to continue in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember's oldest supported LTS no longer needs the old modules api polyfill and has first-class components. This allows us to drop a whole bunch of complexity.
This PR also includes a refactor of the test suite to get everything onto scenario-tester, so that everything respects the same support matrix. As a practical matter, this means some tests that were co-located within their packages will move into tests/scenarios, because it's somewhat annoying to make it work otherwise. As a benefit, this will improve windows test coverage because all the newer-style tests run on both windows and unix and the older ones did not.