Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline template compilation, part 2 #1276

Merged
merged 31 commits into from
Nov 17, 2022
Merged

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 7, 2022

#1242 refactored the stage1 (addon compatibility) template compilation to use the new capabilities of babel-plugin-ember-template-compilation 2.0-alpha.

This PR will do the same for the stage3 (final app build) template compilation.

TODOs and areas to cleanup:

  • app.ts babel config changes
  • load-ember-template-compiler.ts
  • babel-plugin-inline-hbs-deps*
  • template-compiler-node.ts
  • template-compiler-common.ts
  • patch-template-compiler.ts
  • ember-template-compiler-types.ts
  • core/src/resolver.ts
  • compat/src/resolver.ts
  • release babel-plugin-ember-template-compilation

@ef4 ef4 added the internal label Nov 7, 2022
ef4 added 3 commits November 7, 2022 17:45
This removes all the template resolver machinery, the next step will be to build it back up on the new API.
@ef4
Copy link
Contributor Author

ef4 commented Nov 9, 2022

Next steps here:

  • refactor the resolver tests, probably using code-equality-assertions since we're eliminating the need for the explicit dependenciesOf API
  • switch most cases to use lexical scope. The only case that can't is a component with an un-associated template.
    • need to confirm that {{component}} helper is OK with taking lexically scope component classes as input (for the cases where it's being used for currying and can't just be replaced outright)

ef4 added 24 commits November 9, 2022 08:46
I thought we could take first-class helper support for granted since it was supposed to be introduced before 3.28 (our oldest supported ember), but due to:

emberjs/ember.js#19878

we can't rely on it until ember 4.2.
So that our tests can keep using the version that doesn't need the helper-bug hack.
@ef4 ef4 merged commit 752d74b into main Nov 17, 2022
@ef4 ef4 deleted the e-template-compilation-refactor branch November 17, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant