Code

Upgrade resolver tests#1321

Code

Merged

ef4 merged 91 commits intoembroider-build:mainembroider-build/embroider:mainfrom void-mAlex:upgrade-resolver-testsvoid-mAlex/embroider:upgrade-resolver-testsCopy head branch name to clipboardJan 25, 2023

+690-513

Commits

Commits on Jan 8, 2023

• refactor "angle contextual component, lower" test

  void-mAlex

  committed
  5296ec1

• refactor "optional component missing in mustache" test

  void-mAlex

  committed
  8d8f629

• refactor "component rules can be expressed via component helper" test

  void-mAlex

  committed
  f9e208a

• refactor "optional component missing in mustache block" test

  void-mAlex

  committed
  aab823a

Commits on Jan 9, 2023

• remove duplicate test that was refactored in:

  Show description for fcbc32f
  void-mAlex

  committed
  fcbc32f

• refactor "optional component declared as element missing in mustache block" test

  void-mAlex

  committed
  40d3b79

• refactor "optional component missing in element" test

  void-mAlex

  committed
  e501140

• refactor "class defined helper not failing if there is no arguments" test

  void-mAlex

  committed
  370553e

• refactor "class defined helper not failing with arguments" test

  void-mAlex

  committed
  3618fb0

• refactor "helper defined in component not failing if there is no arguments" test

  void-mAlex

  committed
  ff9aa15

• refactor "class defined component not failing if there is a block" test

  void-mAlex

  committed
  306a2f4

• refactor "class defined component not failing with arguments" test

  void-mAlex

  committed
  95c371e

• refactor "mustache missing, no args" test

  void-mAlex

  committed
  7fee8c6

• refactor "mustache missing, with args" test

  void-mAlex

  committed
  79149f0

• refactor "string literal passed to "helper" keyword in content position" test

  void-mAlex

  committed
  a1bc1b1

• refactor "string literal passed to "modifier" keyword in content position" test

  void-mAlex

  committed
  ab428ac

Commits on Jan 10, 2023

• refactor "modifier currying using the "modifier" keyword" test

  void-mAlex

  committed
  5fbff82

• refactor "built-in components are ignored when used with the component helper" test

  void-mAlex

  committed
  87784db

• refactor "built-in helpers are ignored when used with the "helper" keyword" test

  void-mAlex

  committed
  7c20829

• refactor "built-in modifiers are ignored when used with the "modifier" keyword" test

  void-mAlex

  committed
  13f639e

• refactor "component helper with direct addon package reference" test

  void-mAlex

  committed
  269a6ea

• refactor "component helper with direct addon package reference to a renamed package" test

  void-mAlex

  committed
  8ef0f50

• refactor "angle bracket invocation of component with @ syntax" test

  Show description for 3f29c05
  void-mAlex

  committed
  3f29c05

Commits on Jan 12, 2023

• reenable ast transform

  Show description for 85548a0
  void-mAlex

  committed
  85548a0

• refactor "angle bracket invocation of component with @ syntax - self reference inside node_modules" test

  void-mAlex

  committed
  776ed79

• refactor "helper with @ syntax" test

  void-mAlex

  committed
  58fe874

• refactor "helper with @ syntax and direct addon package reference to a renamed package" test

  void-mAlex

  committed
  9d11b48

• refactor "string literal passed to "helper" keyword in helper position" test

  void-mAlex

  committed
  e2e494f

• refactor "helper currying using the "helper" keyword" test

  void-mAlex

  committed
  c3a8c2d

• refactor "string literal passed to "modifier" keyword in helper position" test

  void-mAlex

  committed
  199e144

• refactor "string literal passed to component helper fails to resolve" test

  void-mAlex

  committed
  50b536e

• refactor "string literal passed to "helper" keyword fails to resolve" test

  void-mAlex

  committed
  6bed6d5

• refactor "string literal passed to "modifier" keyword fails to resolve" test

  void-mAlex

  committed
  61239b0

• refactor "string literal passed to component helper fails to resolve when staticComponents is off" test

  void-mAlex

  committed
  ad8d530

• refactor "string literal passed to "helper" keyword fails to resolve when staticHelpers is off" test

  void-mAlex

  committed
  9e99e09

• refactor "string literal passed to "modifier" keyword fails to resolve when staticModifiers is off" test

  void-mAlex

  committed
  5be7028

• refactor "angle component, js and hbs" test

  void-mAlex

  committed
  94f1542

• refactor "nested angle component, js and hbs" test

  void-mAlex

  committed
  eb6f7cf

• refactor "angle component missing" test

  void-mAlex

  committed
  87bcd8e

• refactor "missing subexpression with args" test

  void-mAlex

  committed
  75a9c83

• refactor "missing subexpression no args" test

  void-mAlex

  committed
  a350739

• refactor "emits no helpers when staticHelpers is off" test

  void-mAlex

  committed
  74debc9

• refactor "helper as component argument" test

  void-mAlex

  committed
  031e5e1

• refactor "helper as html attribute" test

  void-mAlex

  committed
  9d2095e

• refactor "missing modifier" test

  void-mAlex

  committed
  ceb27c1

• refactor "emits no modifiers when staticModifiers is off" test

  void-mAlex

  committed
  deef069

• refactor "modifier on component" test

  void-mAlex

  committed
  ece8349

• refactor "modifier on contextual component" test

  void-mAlex

  committed
  79e74ff

• refactor "modifier provided as an argument" test

  void-mAlex

  committed
  a36a542

• *refactor "contextual modifier" test

  void-mAlex

  committed
  a99f87c

• refactor "local binding takes precedence over helper in bare mustache" test

  void-mAlex

  committed
  140766a

• refactor "local binding takes precedence over component in element position" test

  void-mAlex

  committed
  ca72f6b

• refactor "local binding takes precedence over modifier" test

  void-mAlex

  committed
  c8b3592

• refactor "angle components can establish local bindings" test

  void-mAlex

  committed
  dc8cc0d

• refactor "local binding only applies within block" test

  void-mAlex

  committed
  195dbeb

• refactor "ignores builtins" test

  void-mAlex

  committed
  78a2e92

• refactor "ignores dot-rule curly component invocation, inline" test

  void-mAlex

  committed
  52fff6a

• refactor "ignores dot-rule curly component invocation, block" test

  void-mAlex

  committed
  c86472c

• *refactor "respects yieldsSafeComponents rule, position 0" test

  void-mAlex

  committed
  8123d4d

• refactor "respects yieldsSafeComponents rule on element, position 0" test

  void-mAlex

  committed
  468ff88

• *refactor "respects yieldsSafeComponents rule, position 1" test

  void-mAlex

  committed
  d49db93

• *refactor "respects yieldsSafeComponents rule, position 0.field" test

  void-mAlex

  committed
  4cd8004

• *refactor "respects yieldsSafeComponents rule, position 1.field" test

  void-mAlex

  committed
  08cf0b2

• refactor "acceptsComponentArguments argument name may include optional @" test

  void-mAlex

  committed
  b3497b7

• refactor "acceptsComponentArguments on mustache with component subexpression" test

  void-mAlex

  committed
  7af9bb0

• refactor "acceptsComponentArguments matches co-located template" test

  void-mAlex

  committed
  baf1442

• *refactor "element block params are not in scope for element's own attributes" test

  void-mAlex

  committed
  fcdd95d

• refactor "acceptsComponentArguments on mustache with invalid literal" test

  void-mAlex

  committed
  aa3b341

• refactor "acceptsComponentArguments interior usage of path generates no warning" test

  void-mAlex

  committed
  5dbdbb5

• refactor "acceptsComponentArguments interior usage of this.path generates no warning" test

  void-mAlex

  committed
  e9eee19

• refactor "acceptsComponentArguments interior usage of @path generates no warning" test

  void-mAlex

  committed
  d200e44

• refactor "safeToIgnore a missing component" test

  void-mAlex

  committed
  8b4681e

• *refactor safeToIgnore a present component" test

  void-mAlex

  committed
  829c21e

• *refactor "respects yieldsArguments rule for positional block param, angle" test

  void-mAlex

  committed
  53f01cf

• refactor "respects yieldsArguments rule for positional block param, curly" test

  void-mAlex

  committed
  6a5197a

• refactor "respects yieldsArguments rule for hash block param" test

  void-mAlex

  committed
  5b7db62

• refactor "yieldsArguments causes warning to propagate up lexically, angle" test

  void-mAlex

  committed
  12e4f60

• refactor "yieldsArguments causes warning to propagate up lexically, curl" test

  void-mAlex

  committed
  9ceeef7

• refactor "yieldsArguments causes warning to propagate up lexically, multiple levelsl" test

  void-mAlex

  committed
  176fcce

• *refactor "respects invokes rule on a component" test

  void-mAlex

  committed
  df50d1c

• *refactor "respects invokes rule on a non-component app template" test

  void-mAlex

  committed
  556e84d

• *refactor "respects invokes rule on a non-component addon template" test

  void-mAlex

  committed
  c8f6e24

• refactor "rejects arbitrary expression in component helper" test

  void-mAlex

  committed
  1a62997

• refactor "ignores any non-string-literal in "helper" keyword" test

  void-mAlex

  committed
  c21f6d1

• refactor "ignores any non-string-literal in "modifier" keyword" test

  void-mAlex

  committed
  62eddd2

• refactor "trusts inline ensure-safe-component helper" test

  void-mAlex

  committed
  2e0e1f0

Commits on Jan 24, 2023

• skip failing tests when static flags true for modifier and helpers

  void-mAlex

  committed
  23cec32

• fix typo in test expectation

  void-mAlex

  committed
  aa40203

• remove inner expects on code that is suppposed to throw anyway

  void-mAlex

  committed
  ca5d503

• preserve paths to alpha.js files and skip tests

  void-mAlex

  committed
  3e71c01

• Merge branch 'main' into upgrade-resolver-tests

  ef4

  committed
  8da44e8