Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the
.npmrc
settings from the pnpm RFC.Additionally, with these settings we initially had the following violations
kind of a big list
This PR aims to remove as many violations in possible.
What lead me here?
Apparently, JSDom has an optional peerDep in
canvas
, here: jsdom/jsdom@16.7.0...22.1.0#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L55-L60 (comparing our version with latest, to show it's been there a while)Now, this is an optional peer, so I think more investigation is needed in the repo that started throwing errors about canvas trying to be required from jsdom (and note the above messaging from --resolution-only doesn't even mention jsdom/canvas).
However, trying to eliminate the known peer issues (as identified by
pnpm i --resolution-only
) is still good for us and our users.