Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strictmode deps #1485

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Jun 28, 2023

This brings in the .npmrc settings from the pnpm RFC.

Additionally, with these settings we initially had the following violations

kind of a big list

 WARN  Issues with peer dependencies found
packages/babel-loader-8
└─┬ babel-loader 8.2.2
  └── ✕ missing peer webpack@>=2
Peer dependencies that should be installed:
  webpack@>=2

packages/compat
└─┬ ember-engines 0.8.23
  ├── ✕ missing peer ember-source@"^3.12 || 4"
  └── ✕ missing peer @ember/legacy-built-in-components@"*"
Peer dependencies that should be installed:
  @ember/legacy-built-in-components@"*"  ember-source@"^3.12 || 4"

packages/router
└─┬ ember-source 4.12.0
  ├── ✕ missing peer @glimmer/component@^1.1.2
  └─┬ ember-auto-import 2.6.3
    ├─┬ babel-loader 8.2.2
    │ └── ✕ missing peer webpack@>=2
    ├─┬ css-loader 5.2.6
    │ └── ✕ missing peer webpack@"^4.27.0 || ^5.0.0"
    ├─┬ mini-css-extract-plugin 2.5.3
    │ └── ✕ missing peer webpack@^5.0.0
    └─┬ style-loader 2.0.0
      └── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"
Peer dependencies that should be installed:
  @glimmer/component@^1.1.2  webpack@">=5.0.0 <6.0.0"

packages/util
└─┬ ember-resolver 10.1.0
  └── ✕ unmet peer ember-source@^4.8.3: found 4.6.0

test-packages/sample-transforms
├─┬ @ember/test-helpers 2.9.3
│ └─┬ ember-destroyable-polyfill 2.0.3
│   └─┬ ember-compatibility-helpers 1.2.6
│     └─┬ babel-plugin-debug-macros 0.2.0
│       └── ✕ missing peer @babel/core@^7.0.0-beta.42
├─┬ ember-load-initializers 2.1.2
│ └─┬ ember-cli-typescript 2.0.2
│   ├─┬ @babel/plugin-proposal-class-properties 7.16.7
│   │ ├── ✕ missing peer @babel/core@^7.0.0-0
│   │ └─┬ @babel/helper-create-class-features-plugin 7.21.8
│   │   └── ✕ missing peer @babel/core@^7.0.0
│   └─┬ @babel/plugin-transform-typescript 7.4.5
│     ├── ✕ missing peer @babel/core@^7.0.0-0
│     └─┬ @babel/plugin-syntax-typescript 7.21.4
│       └── ✕ missing peer @babel/core@^7.0.0-0
├─┬ ember-source 3.26.0
│ ├─┬ @babel/plugin-transform-block-scoping 7.21.0
│ │ └── ✕ missing peer @babel/core@^7.0.0-0
│ ├─┬ @babel/plugin-transform-object-assign 7.18.6
│ │ └── ✕ missing peer @babel/core@^7.0.0-0
│ └─┬ @glimmer/vm-babel-plugins 0.77.3
│   └─┬ babel-plugin-debug-macros 0.3.4
│     └── ✕ missing peer @babel/core@^7.0.0
├─┬ eslint-plugin-node 9.0.1
│ ├── ✕ missing peer eslint@>=5.16.0
│ └─┬ eslint-plugin-es 1.4.1
│   └── ✕ missing peer eslint@>=4.19.1
├─┬ ember-qunit 6.2.0
│ └── ✕ unmet peer ember-source@>=3.28: found 3.26.0
└─┬ ember-resolver 10.1.0
  └── ✕ unmet peer ember-source@^4.8.3: found 3.26.0
Peer dependencies that should be installed:
  @babel/core@">=7.0.0 <8.0.0"  eslint@>=5.16.0

test-packages/support
└─┬ ember-resolver 10.1.0
  └── ✕ unmet peer ember-source@^4.8.3: found 3.26.0

tests/addon-template
└─┬ ember-resolver 10.1.0
  └── ✕ unmet peer ember-source@^4.8.3: found 4.6.0

tests/app-template
└─┬ ember-resolver 10.1.0
  └── ✕ unmet peer ember-source@^4.8.3: found 4.6.0

tests/scenarios
├─┬ bootstrap 4.3.1
│ ├── ✕ missing peer jquery@"1.9.1 - 3"
│ └── ✕ missing peer popper.js@^1.14.7
├─┬ ember-bootstrap 5.0.0
│ ├─┬ ember-auto-import 2.6.3
│ │ ├─┬ babel-loader 8.2.2
│ │ │ └── ✕ missing peer webpack@>=2
│ │ ├─┬ css-loader 5.2.6
│ │ │ └── ✕ missing peer webpack@"^4.27.0 || ^5.0.0"
│ │ ├─┬ mini-css-extract-plugin 2.5.3
│ │ │ └── ✕ missing peer webpack@^5.0.0
│ │ └─┬ style-loader 2.0.0
│ │   └── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"
│ ├─┬ @ember/render-modifiers 2.0.5
│ │ └── ✕ unmet peer ember-source@"^3.8 || ^4.0.0": found 5.2.0-beta.1
│ └─┬ ember-element-helper 0.6.1
│   └── ✕ unmet peer ember-source@"^3.8 || 4": found 5.2.0-beta.1
├─┬ ember-data 5.0.0
│ ├── ✕ unmet peer @ember/string@^3.1.1: found 3.0.1
│ ├─┬ @ember-data/store 5.0.0
│ │ ├── ✕ missing peer @glimmer/tracking@^1.1.2
│ │ └── ✕ unmet peer @ember/string@^3.1.1: found 3.0.1
│ ├─┬ @ember-data/model 5.0.0
│ │ ├── ✕ unmet peer @ember/string@^3.1.1: found 3.0.1
│ │ └─┬ ember-cached-decorator-polyfill 1.0.1
│ │   └── ✕ unmet peer ember-source@"^3.13.0 || ^4.0.0": found 5.2.0-beta.1
│ ├─┬ @ember-data/adapter 5.0.0
│ │ └── ✕ unmet peer @ember/string@^3.1.1: found 3.0.1
│ ├─┬ @ember-data/debug 5.0.0
│ │ └── ✕ unmet peer @ember/string@^3.1.1: found 3.0.1
│ └─┬ @ember-data/serializer 5.0.0
│   └── ✕ unmet peer @ember/string@^3.1.1: found 3.0.1
├─┬ ember-source 5.2.0-beta.1
│ └─┬ router_js 8.0.3
│   └── ✕ missing peer rsvp@^4.8.5
├─┬ ember-source 5.0.0
│ └── ✕ missing peer @glimmer/component@^1.1.2
├─┬ ts-node 10.9.1
│ └── ✕ missing peer @types/node@"*"
├─┬ @rollup/plugin-babel 5.3.1
│ ├── ✕ unmet peer rollup@^1.20.0||^2.0.0: found 3.23.0
│ └─┬ @rollup/pluginutils 3.1.0
│   └── ✕ unmet peer rollup@^1.20.0||^2.0.0: found 3.23.0
└─┬ ember-engines 0.8.23
  └── ✕ unmet peer ember-source@"^3.12 || 4": found 5.2.0-beta.1
Peer dependencies that should be installed:
  @glimmer/component@^1.1.2  jquery@"1.9.1 - 3"         webpack@">=5.0.0 <6.0.0"
  @glimmer/tracking@^1.1.2   popper.js@^1.14.7
  @types/node@"*"            rsvp@^4.8.5

tests/ts-app-template
├─┬ @babel/eslint-parser 7.21.3
│ └── ✕ missing peer eslint@"^7.5.0 || ^8.0.0"
└─┬ eslint-plugin-n 15.7.0
  ├── ✕ missing peer eslint@>=7.0.0
  ├─┬ eslint-plugin-es 4.1.0
  │ └── ✕ missing peer eslint@>=4.19.1
  └─┬ eslint-utils 3.0.0
    └── ✕ missing peer eslint@>=5
Peer dependencies that should be installed:
  eslint@">=7.5.0 <8.0.0 || >=8.0.0 <9.0.0"

Done in 16s

This PR aims to remove as many violations in possible.

What lead me here?

Apparently, JSDom has an optional peerDep in canvas, here: jsdom/jsdom@16.7.0...22.1.0#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L55-L60 (comparing our version with latest, to show it's been there a while)

Now, this is an optional peer, so I think more investigation is needed in the repo that started throwing errors about canvas trying to be required from jsdom (and note the above messaging from --resolution-only doesn't even mention jsdom/canvas).

However, trying to eliminate the known peer issues (as identified by pnpm i --resolution-only) is still good for us and our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant